[RFC 3/3] ath10k: add support for HTT 3.0

Kalle Valo kvalo at qca.qualcomm.com
Thu Aug 8 05:42:46 EDT 2013


Michal Kazior <michal.kazior at tieto.com> writes:

> On 8 August 2013 11:22, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
>> Michal Kazior <michal.kazior at tieto.com> writes:
>>
>>> On 8 August 2013 11:05, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
>>
>>>> This debug print is good to have, but with the new htt version it would
>>>> be good to print it always using the info level. For example, can we add
>>>> it to the same line with "firmware %s booted" string?
>>>
>>> HTT target version is not known when firmware boots up. It's not known
>>> until everything other (HTC, WMI) is set up. We then send a version
>>> request command and we get a response.
>>
>> Oh, missed that.
>>
>>> We need to print it in a separate line.
>>
>> Or could we print the "firmware booted" message later?
>
> I'm worried it may be error-prone in case of firmware loading failure
> in-between (i.e. firmware is booted, but WMI init fails). We'd need to
> print the firmware version in the error path then.

True, let's just print in a separate line. We can worry about compacting
it later.

-- 
Kalle Valo



More information about the ath10k mailing list