[BUG] aiaiai-test-patchset removes obj dirs too early
computersforpeace at gmail.com
Tue Aug 4 16:49:42 PDT 2015
On Tue, Aug 04, 2015 at 11:25:24PM +0000, Keller, Jacob E wrote:
> > -----Original Message-----
> > From: aiaiai [mailto:aiaiai-bounces at lists.infradead.org] On Behalf Of Brian
> > Norris
> > diff --git a/aiaiai-test-patchset b/aiaiai-test-patchset
> > index 85fd0575dd4b..92ca3dfe8a40 100755
> > --- a/aiaiai-test-patchset
> > +++ b/aiaiai-test-patchset
> > @@ -248,6 +248,10 @@ test_configuration()
> > aiaiai-diff-log $verbose $preserve "$tmpdir/diff-for-diff-log"
> > "$log1.stderr.log" \
> > -w "$tmpdir" "$log2.stderr.log" >
> > "$tmpdir/$config.stderr.diff"
> > + # MUST sync with bisect test before removing build artifacts
> > + [ -z "$pid_bisect" ] || wait "$pid_bisect" || die "aiaiai-test-
> > bisectability failed"
> > + verbose "Done with bisectability test"
> > +
> This seems fine to me. I don't think we lose that much parallelism
> here. I don't think this will drastically reduce performance, and it
> definitely avoids the issue.
> I'll go ahead and queue this patch up.
Actually, hold off there. There are some problems I didn't notice, that
get exposed with multi-config runs. I'll work it out and send an addon
patch shortly, I expect.
With this patch, I've seen this sample error:
[2015-08-04 16:29:07] aiaiai-test-patchset: Fatal error: aiaiai-test-bisectability failed
More information about the aiaiai