[PATCH] aiaiai-email-lda: use the References mail header

Robert Jarzmik robert.jarzmik at free.fr
Fri Nov 7 12:37:10 PST 2014


Artem Bityutskiy <dedekind1 at gmail.com> writes:

>> diff --git a/doc/README b/doc/README
>> index 0e699a2..0e6571c 100644
>> --- a/doc/README
>> +++ b/doc/README
>> @@ -102,6 +102,28 @@ The 'aiaiai-test-patchset' script does all the testing work and outputs the
>>  test results to stdout. 'aiaiai-email-test-patchset' captures the output and
>>  sends it back to the patch submitter.
>>  
>> +A more complicated mail setup dealing with forwards and multi-part emails
>> +would be :
>> +$ cat /home/aiaiai/bin/my-aiaiai-lda
>> +	#!/bin/sh
>> +	formail_opt=""
>
> Thanks. But would you please quote variables. This is the convention we
> follow in this set of scripts, for our on good.

Well, I tried, this doesn't work anymore. The mail reason I think is that for
each sentence such as :
to="$(formail -c -z -x "To:" < $mail)"
                                \-> here $mail is actually quoted I think.
> How about this:
>
> cat "$mail" | eval formail "$(formail_opt -d -s
> "$HOME/git/email/aiaiai-email-lda" v --reap-archive=43200
> --reap-incomplete=10 -- "$HOME/aiaiai-workdir")" >>
> "$HOME/aiaiai-logs/email-lda.log"

How about droping alltogether this part of the patch, which is a README and not
actual aiaiai code.

> Today I'd choose python to write this stuff. Bat back to that time I did
> not know python :-)
Yeah, python rocks :)

> In your case, you call mktemp. You can rely on the fact that it will
> return a shell-friendly name, yes. But I ask to quote just for the
> consistency.

OK. Can we drop the README part then ? I particulary dislike all shell stuff,
quoting drives me crazy and I never get it right.

Cheers.

-- 
Robert



More information about the aiaiai mailing list