[PATCH] aiaiai-test-patchset: optimize disk space

[Artem Bityutskiy]

On Thu, 2014-11-06 at 22:30 +0000, Keller, Jacob E wrote:
> On Thu, 2014-11-06 at 20:46 +0100, Robert Jarzmik wrote:
> > When compiling multiple defconfigs, remove the build tree between
> > each compilation to spare disk space.
> > 
> > In this way the build trees don't accumulate on the disk while
> > testing the same patchset, and the patchset scales with the
> > number of defconfigs, which is not limiting the build anymore.
> > 
> > Signed-off-by: Robert Jarzmik <robert.jarzmik at free.fr>
> > ---
> >  aiaiai-test-patchset | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/aiaiai-test-patchset b/aiaiai-test-patchset
> > index b3ab3f5..952c625 100755
> > --- a/aiaiai-test-patchset
> > +++ b/aiaiai-test-patchset
> > @@ -239,7 +239,9 @@ test_configuration()
> >  	verbose "Done with patched kernel"
> >  
> >  	aiaiai-diff-log $verbose $preserve "$tmpdir/diff-for-diff-log" "$log1.stderr.log" \
> > -		-w "$tmpdir" "$log2.stderr.log" > "$tmpdir/$config.stderr.diff"
> > +			-w "$tmpdir" "$log2.stderr.log" > "$tmpdir/$config.stderr.diff"
> > +	[ -d "$obj1" ] && (verbose "Removing $obj1"; rm -rf -- "$obj1" >&2)
> > +	[ -d "$obj2" ] && (verbose "Removing $obj2"; rm -rf -- "$obj2" >&2)
>  
> 
> Could you check the configuration settings to ensure we don't delete
> these if preserve_files configuration option is set? We check this in
> the cleanup_handler, and it is useful for debugging to not have these
> files deleted. The option is off by default, I think it's actually a
> command line paramater at this layer of aiaiai...

A commentary would also be appreciated by someone reading this code
later. Something like:

# Remove the build directories (unless "-p" was specified) in order
# to consume less disk space.