[PATCH] test-patchset: allow proper support for randconfig

[Artem Bityutskiy]

On Thu, 2014-07-10 at 16:38 -0700, Jacob Keller wrote:
> Make randconfig pre-generate a configuration so that the pre and post
> patch series builds use the same configuration (vs using random configs
> each time). In addition, append the random configuration whenever there
> is a build diff, so that the user can see.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>

Ideally, new functionality should be reflected in some kind of
documentation. E.g., --help is sort of documentation.

> ---
>  aiaiai-test-patchset | 27 ++++++++++++++++++++++-----
>  1 file changed, 22 insertions(+), 5 deletions(-)
> 
> diff --git a/aiaiai-test-patchset b/aiaiai-test-patchset
> index d65f699c3251..da08b31b9867 100755
> --- a/aiaiai-test-patchset
> +++ b/aiaiai-test-patchset
> @@ -160,11 +160,6 @@ test_configuration()
>  
>  	[ -z "$arch" ] || arch_opt="-a $arch${cross:+",$cross"}"
>  
> -	if [ -n "$confdir" ]; then
> -		defconfig="$confdir/$defconfig"
> -		[ -f "$defconfig" ] || die "$defconfig is not available"
> -	fi
> -
>  	if [ -n "$bisectability" ]; then
>  		# We share the same source tree with 'aiaiai-test-bisectability', so
>  		# wait for it (it could be run at the previous iteration)
> @@ -179,6 +174,23 @@ test_configuration()
>  
>  	git --git-dir="$(git_dir "$cloned_kernel1")" reset $quiet --hard "$commit_id1" >&2
>  
> +	# Enable use of a random condiguration that is stable between the
> +	# before and after tests. If we just used 'randconfig' by default, then
> +	# we wouldn't be testing the before and after kernels with the same
> +	# configuration. We do this even if we have specified a confdir.
> +	if [ "$defconfig" = "randconfig" ]; then
> +			# Generate a random configuration
> +			make -C $cloned_kernel1 ${arch:+ARCH="$arch"} \
> +				${cross:+CROSS_COMPILE="$cross"} -- "$defconfig"

In theory, $cloned_kernel1 may contain white-spaces or something, may be
some day or by a mistake, or misuse. I suggest to qyote it.

Otherwise looks good.

-- 
Best Regards,
Artem Bityutskiy