[PATCH 3/3] aiaiai-make-project: Support non-kernel project builds

[Keller, Jacob E]

> -----Original Message-----
> From: Artem Bityutskiy [mailto:dedekind1 at gmail.com]
> Sent: Wednesday, May 28, 2014 12:24 AM
> To: Keller, Jacob E
> Cc: aiaiai at lists.infradead.org
> Subject: Re: [PATCH 3/3] aiaiai-make-project: Support non-kernel project
> builds
> 
> On Tue, 2014-05-27 at 10:56 -0700, Jacob Keller wrote:
> > It is often useful to run tests against non-kernel projects, such as
> > ethtool. This patch renames aiaiai-make-kernel to aiaiai-make-project,
> > and adds support for detecting kernel, ./configure, and ./autogen.sh
> > style projects.
> >
> > It will be a slow process for actually converting all tools to work with
> > non-kernel builds, and various options and documentation are only
> > relevant for kernel builds, but this is a small step in the more generic
> > direction.
> >
> > Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> 
> I am not sure it having a separate kernel-specific script is a bad idea.
> Did you consider adding a _separate_ aiaiai-make-project script, which
> will "probe" the source tree, and if it detects that the it is dealing
> with Linux kernel, it would just call 'aiaiai-make-kernel', otherwise it
> would do a generic build.
> 
> Indeed, all the 'O=', 'ARCH=' and other kernel-specific stuff is
> probably never going to be needed in the generic script, so why not to
> have them separate? There will be some duplication, but probably not
> that much.
> 

Actually there is probably very low duplication, if I extract the actual kernel build part into aiaiai-make-kernel, and then keep all the other handling stuff separate. That makes sense and I can work on those changes.

Thanks,
Jake

> What do you think?
> 
> --
> Best Regards,
> Artem Bityutskiy