[PATCH 2/3] aiaiai-test-patchset: make checkpatch optional like other checkers

Keller, Jacob E jacob.e.keller at intel.com
Wed May 28 14:13:39 PDT 2014

> -----Original Message-----
> From: Artem Bityutskiy [mailto:dedekind1 at gmail.com]
> Sent: Wednesday, May 28, 2014 12:19 AM
> To: Keller, Jacob E
> Cc: aiaiai at lists.infradead.org
> Subject: Re: [PATCH 2/3] aiaiai-test-patchset: make checkpatch optional
> like other checkers
> On Tue, 2014-05-27 at 10:56 -0700, Jacob Keller wrote:
> > This modifies behavior of aiaiai such that checkpatch will be an option
> > much like sparse and coccinelle. In addition, only work if checkpatch.pl
> > is found in the project at the requested location. Will disable
> > checkpatch if it cannot be found.
> >
> > Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> Generally good patch - it is more consistent to have --checkpatch
> similarly to other checkers. Checkpatch is, after all, also a checker,
> so why is it special?
> However, I am concerned about the fact that if I want checkpatch, and I
> somehow screwed up my tree kernel tree, and it is not in there, aiaiai
> will silently proceed instead of loudly failing and telling me that I am
> doing something wrong.
> IOW, I suggest to fail if --checkpatch option is given, but the script
> is absent in the source tree. The help message may mention that this is
> a kernel-specific checker.

Yes, this is in line with the other suggestions for coccinelle, and I think it makes sense.. I will make that change.


> --
> Best Regards,
> Artem Bityutskiy

More information about the aiaiai mailing list