[PATCH aiaiai 7/9] aiaiai: don't display log output from git-find-base
Artem Bityutskiy
dedekind1 at gmail.com
Mon Apr 28 23:25:25 PDT 2014
On Mon, 2014-04-28 at 18:51 +0000, Keller, Jacob E wrote:
> On Fri, 2014-04-25 at 17:29 -0700, Artem Bityutskiy wrote:
> > On Wed, 2014-04-09 at 15:26 -0700, Jacob Keller wrote:
> > > - commit="$(git --git-dir="$(git_dir "$pcfg_path")" find-base "$pcfg_branch" "${branch_base:-$pcfg_branch}^!" < "$mbox" \
> > > + commit="$(git --git-dir="$(git_dir "$pcfg_path")" find-base "$pcfg_branch" "${branch_base:-$pcfg_branch}^!" 2>>"$tmp_find_base" < "$mbox" \
> > > || verbose "No matching base commit in project $prj" )"
> >
> > I'd made these lines shorter, but this is matter of taste. Pushed,
> > thanks!
> >
>
> I would as well, but I wasn't sure the best way in shell to do this..
> Any suggestions?
Defining a temporary variables, may be, like:
git_dir_opt="--git-dir=$(git_dir "$pcfg_path")"
branches=""$pcfg_branch" ${branch_base:-$pcfg_branch}^!"
By the way, I think you wanted 'git merge-base' here.
--
Best Regards,
Artem Bityutskiy
More information about the aiaiai
mailing list