[PATCH 1/4] aiaiai-test-patchset: move --targets option down

[Keller, Jacob E]

This whole series looks good besides the one nit about -timeout on the
patch I already replied to.

Thanks!
Jake

On Thu, 2014-04-24 at 17:13 -0700, dedekind1 at gmail.com wrote:
> From: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
> 
> This patch has no functional changes. It is just a clean-up which makes the
> help output a tiny bit easier to follow by moving --target out of the
> block of options related to checkers. Also, it changes the orger of option
> handling to match the order in the help output.
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
> ---
>  aiaiai-test-patchset | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/aiaiai-test-patchset b/aiaiai-test-patchset
> index 7bf1413..45527f9 100755
> --- a/aiaiai-test-patchset
> +++ b/aiaiai-test-patchset
> @@ -77,7 +77,6 @@ Options:
>                           stand-alone defconfig files instead;
>    -p, --preserve         preserve all the temporary files - do not clean up;
>        --bisectability    test bisectability;
> -      --targets          list of make targets to build (defaults to all)
>        --sparse           check with sparse while building;
>        --smatch           check with smatch while building;
>        --cppcheck         check with cppcheck while building;
> @@ -87,6 +86,7 @@ Options:
>                           an mbox file with quick fixes which will be applied
>                           first and the user patch-set will be tested on top of
>                           the fixes;
> +      --targets          list of make targets to build (defaults to all)
>    -K  --keywords=FILE    match keywords from FILE against the patch;
>    -M, --kmake-opts       additional options to append to the final kernel
>                           compilation 'make' command
> @@ -239,7 +239,7 @@ cleanup_handler()
>  }
>  set_cleanup_handler cleanup_handler
>  
> -TEMP=`getopt -n $PROG -o j:,c:,i:,w:,C:,p,Q:,K:,M:,v,h --long jobs:,commit-id:,input:,workdir:,logdir:,confdir:,preserve,bisectability,targets:,sparse,smatch,cppcheck,coccinelle,quick-fixes:,keywords:,kmake-opts:,verbose,help -- "$@"` ||
> +TEMP=`getopt -n $PROG -o j:,c:,i:,w:,C:,p,Q:,K:,M:,v,h --long jobs:,commit-id:,input:,workdir:,logdir:,confdir:,preserve,bisectability,sparse,smatch,cppcheck,coccinelle,quick-fixes:,targets:,keywords:,kmake-opts:,verbose,help -- "$@"` ||
>  	fail_usage ""
>  eval set -- "$TEMP"
>  
> @@ -250,11 +250,11 @@ commit_id1=HEAD
>  mbox=
>  bisectability=
>  sparse=
> -targets="all"
>  smatch=
>  cppcheck=
>  coccinelle=
>  quick_fixes=
> +targets="all"
>  keywords=
>  kmake_opts=
>  verbose=
> @@ -290,17 +290,9 @@ while true; do
>  	-p|--preserve)
>  		preserve="--preserve"
>  		;;
> -	-Q|--quick-fixes)
> -		quick_fixes="$(opt_check_read "$1" "$2")"
> -		shift
> -		;;
>  	--bisectability)
>  		bisectability="--bisectability"
>  		;;
> -	--targets)
> -		targets="$2"
> -		shift
> -		;;
>  	--sparse)
>  		sparse="--sparse"
>  		program_required "sparse" "See section 'sparse' in doc/README"
> @@ -317,6 +309,14 @@ while true; do
>  		coccinelle="yes"
>  		program_required "spatch" "Usually Linux distribution provide a 'spatch' or 'coccinelle' package"
>  		;;
> +	-Q|--quick-fixes)
> +		quick_fixes="$(opt_check_read "$1" "$2")"
> +		shift
> +		;;
> +	--targets)
> +		targets="$2"
> +		shift
> +		;;
>  	-K|--keywords)
>  		keywords="$(opt_check_read "$1" "$2")"
>  		shift