[PATCH 4/4] aiaiai-checker: ignore debugging output from spatch
Keller, Jacob E
jacob.e.keller at intel.com
Fri Apr 25 09:51:05 PDT 2014
On Thu, 2014-04-24 at 17:13 -0700, dedekind1 at gmail.com wrote:
> From: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
> spatch is a great tool, but it is still not very stable and crashes sometimes,
> in which case it prints a lot of debugging stuff to stderr, which we do not
> want in out logs. Normal warnings go to stdout. Therefore, ignore stderr output
> of spatch.
> And switch to the new style options format instead of using the old style.
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
> helpers/aiaiai-checker | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
> diff --git a/helpers/aiaiai-checker b/helpers/aiaiai-checker
> index 6aa8e79..127aca4 100755
> --- a/helpers/aiaiai-checker
> +++ b/helpers/aiaiai-checker
> @@ -75,13 +75,17 @@ run_coccinelle()
> # Coccinelle is not stable enough so far and dies because of
> # internal issues sometimes or just never stops. So we specify
> # a timeout as well as ignore its error code.
> - flags="-D report -no_show_diff -very_quiet -no_includes -include_headers -timeout 60"
> + flags="-D report --no-show-diff --very-quiet --no-includes --include-headers -timeout 60"
Did you mean to use --timeout here?
> # Run coccinelle for each semantic patch in parallel. This may load the
> # system too heavily, though. We use aiaiai-locker to make sure
> # we have non-scrambled output.
> + #
> + # Also redirect stderr to /dev/null since it crashes sometimes
> + # and prints different kind of uninteresting debugging
> + # information to stderr
> aiaiai-locker -s -l "$tmpdir/lockfile" -c \
> - "spatch $flags -sp_file $spatch $file_to_check" ||: &
> + "spatch $flags --sp-file $spatch $file_to_check" 2> /dev/null ||: &
> pids="$pids $!"
More information about the aiaiai