[PATCH 03/13] dispatcher: use $file instead of $mbox

[Keller, Jacob E]

> -----Original Message-----
> From: Artem Bityutskiy [mailto:dedekind1 at gmail.com]
> Sent: Friday, March 21, 2014 9:16 AM
> To: Keller, Jacob E
> Cc: aiaiai at lists.infradead.org
> Subject: Re: [PATCH 03/13] dispatcher: use $file instead of $mbox
> 
> On Thu, 2014-03-20 at 16:37 -0700, Jacob Keller wrote:
> > diff --git a/email/aiaiai-email-dispatcher-helper b/email/aiaiai-email-
> dispatcher-helper
> > index 9627182326fc..c0c188e50626 100755
> > --- a/email/aiaiai-email-dispatcher-helper
> > +++ b/email/aiaiai-email-dispatcher-helper
> > @@ -99,8 +99,8 @@ tmpdir="$(mktemp -dt "$PROG.XXXX")"
> >  # Run the dispatcher hook
> >  if [ -n "$cfg_dispatch_hook" ]; then
> >  	hook="$(readlink -fv -- "$cfg_dispatch_hook")"
> > -	verbose "Running \"$hook\" on \"$mbox\""
> > -	$hook "$mbox" "$cfgfile"
> > +	verbose "Running \"$hook\" on \"$file\""
> > +	$hook "$file" "$cfgfile"
> 
> But "$file" is not even defined at this point. It is defined later.
> 


This may be an artifact of rebased another patch. In the final code from this series $file is already defined. I was pretty sure it was defined here already... If not you can just drop this patch. I moved the place we call the hook down a few lines.. In my version $file is defined almost as soon as we define $mbox...

Regards,
Jake

> --
> Best Regards,
> Artem Bityutskiy