[PATCH 3/6] aiaiai-email-test-patchset: fix parameter substitution

Jacob Keller jacob.e.keller at intel.com
Mon Mar 10 16:46:11 PDT 2014

The targets parameter was incorrectly failing to add the --targets,
because the substitution did not have a +. This patch corrects the
parameter substitution so that the targets will correctly include the
required option for use with aiaiai-test-patchset directly.

Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
 email/aiaiai-email-test-patchset | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/email/aiaiai-email-test-patchset b/email/aiaiai-email-test-patchset
index a55b4810db07..f3409139c77b 100755
--- a/email/aiaiai-email-test-patchset
+++ b/email/aiaiai-email-test-patchset
@@ -313,7 +313,7 @@ fi
 # Test the path (or patch-set)
 verbose "Test configs \"$pcfg_configs\" branch \"$pcfg_branch\" of \"$pcfg_path\""
 aiaiai-test-patchset $verbose $preserve \
-	${pcfg_targets:--targets "$pcfg_targets"} $bisectability $sparse $smatch $cppcheck $coccinelle \
+	${pcfg_targets:+--targets "$pcfg_targets"} $bisectability $sparse $smatch $cppcheck $coccinelle \
 	-i "$mbox" -j "$cfg_jobs" -c "$pcfg_branch" -w "$tmpdir" \
 	${pcfg_defconfigdir:+-C "$pcfg_defconfigdir"} \
 	${pcfg_unwanted_keywords:+-K "$pcfg_unwanted_keywords"} -- \

More information about the aiaiai mailing list