[PATCH RFC 1/8] aiaiai-sh-functions: remove extra quotes in call to ini_config_get
Keller, Jacob E
jacob.e.keller at intel.com
Fri Mar 7 13:54:13 PST 2014
> -----Original Message-----
> From: Artem Bityutskiy [mailto:dedekind1 at gmail.com]
> Sent: Friday, March 07, 2014 12:34 AM
> To: Keller, Jacob E
> Cc: aiaiai at lists.infradead.org
> Subject: Re: [PATCH RFC 1/8] aiaiai-sh-functions: remove extra quotes in
> call to ini_config_get
> On Fri, 2014-03-07 at 01:28 +0000, Keller, Jacob E wrote:
> > This patch cleans up a case of ini_config_get for grabbing the unwanted
> > keywords variable.
> > Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> Thanks Jacob. Would you please check and possibly address few
> that I gave you? But meanwhile, to save your time, I've pushed this
> series to the devel branch. So you can just do further changes on top of
> your series.
> Best Regards,
> Artem Bityutskiy
Thanks. Generally would prefer to rebase changes like that in, but I'm alright either way. The comment regarding inclusiveness is actually already addressed. I can fixup the comment if you like, but the code already is exclusive (ie: setting it in project overwrites any setting in defaults, rather than merging them) I added the comment because in my mind, it is easy to assume that variable will be inclusive.
I can move the other function to libshell.
More information about the aiaiai