[PATCH 1/2] aiaiai: move most of the aiaiai-email-test-patchset options to the file

Keller, Jacob E jacob.e.keller at intel.com
Thu Mar 6 13:51:44 PST 2014


On Thu, 2014-03-06 at 18:51 +0200, Artem Bityutskiy wrote:
> On Thu, 2014-03-06 at 16:27 +0000, Keller, Jacob E wrote:
> > Much better! I can work on this. I hope to resolve why my local mailer
> > was not sending out the patches.
> > 
> > I wasn't really sure how to do this, but I like this method much
> > better,
> > as it removes the necessity for the cfg_get_value function, which I
> > did
> > not like!
> > 
> > Quick question, how do you think these changes relate to adding
> > options
> > for other programs, and will it work for that..?
> I do not really understand what you mean, sorry.
> > 
> > We have some global options which I would like to add that I wasn't
> > sure
> > how to implement (number of validators, for example).
> Do you mean the "-J" option of aiaiai-email-dispatcher ? I'd move
> everything to the cfg file. At least for the e-mail stuff. So I'd kill
> that -J too and had it in the config file instead.

Yes, but how should I read this? Should I just re-read the config file
inside both files?

> > Also, what about this may have to change once we use the cfg file for
> > all programs and not just the email settings?
> Off the top of my head...
> I guess after doing this for e-mail this can be "pushed down" to
> aiaiai-testp-patchset too. Then may be down to helpers.


> Although probably the base scripts should supported both, so that I
> could either use the cfg file or options (but not mixed). Not sure how
> difficult is that, though. The thing is that aiaiai-test-patchset is
> used as a command-line tool too.

I agree. The command line options here should override settings from the
config file. I think we can make that work actually. (Even allowing both
at once).

But how does one handle the project and such? And also should we really
have to read all the options all the time, or only the ones each file
needs? Certainly easier to do it that way...

It *is* a bit further out though.


More information about the aiaiai mailing list