[aiaiai PATCH v3 07/12] email-lda: process all series directories at the end
Keller, Jacob E
jacob.e.keller at intel.com
Thu Feb 6 13:28:03 PST 2014
On Thu, 2014-02-06 at 18:34 +0200, Artem Bityutskiy wrote:
> On Thu, 2014-02-06 at 12:33 +0200, Artem Bityutskiy wrote:
> > From: Jacob Keller <jacob.e.keller at intel.com>
> > Sometimes the email-lda program can misbehave and a series could end up
> > becoming "complete" but the LDA does not queue it when the last patch was
> > added. This patch modifies the LDA so that it will check all series at the end
> > of each mail and queue them, rather than only checking a series when some
> > thing is added.
> > The primary benefit of this is if a series does not properly get queued, the
> > administrator can come in and manually add the patches to the series
> > directory. Then the series will properly be "queued" after the next email
> > triggers the LDA.
> > This does come at a slight hit in terms of performance as we now have to check
> > whether series are complete for every email. However, the gain in being able
> > to easily fixup and get a series queued again when errors occur is much more
> > useful.
> > Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> Thanks Jacob,
> This is a good change. I've refactored it, and fixed a bug, and tested
> the resulting lda script, seems to work fine. I've submitted it in the
> last series of patches to the mailing list.
> > + # Clear anything from the current mbox
> > + rm -f $mbox
> > +
> > + queue_series "$dir" "$n"
> Here you forgot to check if the series is complete.
> I also did a lot of clean-ups while incorporating your patch. Just to
> make the whole script a bit saner.
I appear to be missing patches 10-16 of that series..
More information about the aiaiai