[PATCH] email-lda: use cover letter subject if available

[Keller, Jacob E]

On Wed, 2014-02-05 at 13:43 +0200, Artem Bityutskiy wrote:
> On Wed, 2014-02-05 at 12:53 +0200, Artem Bityutskiy wrote:
> > From: Jacob Keller <jacob.e.keller at intel.com>
> > 
> > Often, a patch series will be sent with a cover letter which describes the
> > series and is given the '0/n' patch number. Rather than dropping these
> > patches, keep track of them in series. We do this by checking whether the 1/n
> > patch has an "In-Reply-To" header. This usually means that their will be an
> > associated cover letter. Once this is found, rather than sending the patch
> > directly on to the test program, we use the cover letter's subject by using
> > formail to add a special "Series-Subject". This makes it so that the
> > aiaiai-email will end up as a reply to the cover letter which is a bit more
> > aesthetically pleasing to users.
> > 
> > To help this process, a new "series_is_complete" function is added in place of
> > the original series complete check. This function reports whether the series
> > is completely queued, for both cases of cover letter and no cover letter.
> > 
> > Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> 
> Good idea in general.
> 
> > +# Use the series subject if it exists
> > +subj="$(fetch_header "X-Series-Subject" < "$mbox")"
> > +if [[ -z $subj ]]; then
> > +	fetch_header_or_die subj "Subject" < "$mbox"
> > +fi
> 
> But surely it is not enough to only use the cover letter subject? Our
> reply should also be a reply to the cover letter, and refer the cover
> letter in "In-Reply-To:" and "References:"?
> 
> So we need X-Aiaiai-Cover-Letter-ID too, right?
> 
> I guess it is also good to use a more specific "namespace", something
> like "X-Aiaiai-", not just "X-", right? I'd suggest:
> 
> X-Aiaiai-Cover-Letter-ID
> X-Aiaiai-Cover-Letter-Subject
> 
> How does this sound?
> 
> 

That sounds better :) Also possibly might use X-Aiaiai-OldTo in one of
my other patches, which I had a specialized header as well.

Regards,
Jake