[PATCH 02/14] email-test-patchset: move project configuration parsing down a bit
Keller, Jacob E
jacob.e.keller at intel.com
Tue Feb 4 09:46:50 PST 2014
On Tue, 2014-02-04 at 19:27 +0200, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
>
> This patch is a little clean-up which makes the code a bit more consistent. It
> makes sure we first check if the user specified the project, and only then try
> to parse project configuration, not vice-versa.
>
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
> ---
> email/aiaiai-email-test-patchset | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/email/aiaiai-email-test-patchset b/email/aiaiai-email-test-patchset
> index b32ab16..694e008 100755
> --- a/email/aiaiai-email-test-patchset
> +++ b/email/aiaiai-email-test-patchset
> @@ -198,9 +198,6 @@ prj="$(fetch_project_name "$to" "$cfg_ownmail")"
>
> verbose "Project \"$prj\""
>
> -# Fetch project configuration
> -parse_prj_config "$cfgfile" "$prj"
> -
> # Reject the e-mail if the project has not been specified
> if [ -z "$prj" ]; then
> to=
> @@ -217,6 +214,9 @@ EOF
> exit 0
> fi
>
> +# Fetch project configuration
> +parse_prj_config "$cfgfile" "$prj"
> +
> # Check if we have this project in our config file
> if [ -z "$cfg_name" ]; then
> to=
Hmm. I am pretty sure I posted a patch about this in my list. Either
way, if I have I can remove it since you've done this one.
Regards,
Jake
More information about the aiaiai
mailing list