[PATCH 1/2] Remove --check-only option support
Artem Bityutskiy
dedekind1 at gmail.com
Mon Feb 3 11:03:53 EST 2014
From: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
This patch removes the --check-only option because it is useless. I never used
it, and I did not see anyone using it.
Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
---
aiaiai-checker | 19 +------------------
aiaiai-make-kernel | 10 ++--------
2 files changed, 3 insertions(+), 26 deletions(-)
diff --git a/aiaiai-checker b/aiaiai-checker
index 1da8e14..d071bce 100755
--- a/aiaiai-checker
+++ b/aiaiai-checker
@@ -31,7 +31,6 @@ Options:
--smatch check with smatch;
--cppcheck check with cppcheck;
--coccinelle check with coccinelle (spatch);
- --check-only=FILE check only files listed in FILE;
-h, --help show this text and exit.
EOF
}
@@ -90,7 +89,7 @@ cleanup_handler()
}
set_cleanup_handler cleanup_handler
-TEMP=`getopt -n $PROG -o h --long sparse,smatch,cppcheck,coccinelle,check-only:,help -- "$@"` ||
+TEMP=`getopt -n $PROG -o h --long sparse,smatch,cppcheck,coccinelle,help -- "$@"` ||
fail_usage ""
eval set -- "$TEMP"
@@ -100,7 +99,6 @@ run_sparse=
run_smatch=
run_cppcheck=
run_coccinelle=
-check_only=
while true; do
case "$1" in
@@ -120,10 +118,6 @@ while true; do
run_coccinelle=1
program_required "spatch" "Usually Linux distribution provide a 'spatch' or 'coccinelle' package"
;;
- --check-only)
- check_only="$(opt_check_read "$1" "$2")"
- shift
- ;;
-h|--help)
show_usage
exit 0
@@ -148,17 +142,6 @@ if [ -z "$run_sparse" ] && [ -z "$run_smatch" ] && [ -z "$run_cppcheck" ] &&
exit 0
fi
-if [ -n "$check_only" ]; then
- match=
- files="$(cat "$check_only")"
- for file in $files; do
- match="$(printf "%s" "$@" | sed -n "/$(quote_sed_regexp "$file")/p")"
- [ -z "$match" ] || break
- done
-
- [ -n "$match" ] || exit 0
-fi
-
# Run all the tools in background
if [ -n "$run_sparse" ]; then
diff --git a/aiaiai-make-kernel b/aiaiai-make-kernel
index bba9957..edab96a 100755
--- a/aiaiai-make-kernel
+++ b/aiaiai-make-kernel
@@ -46,7 +46,6 @@ Options:
--smatch check with smatch while building;
--cppcheck check with cppcheck while building;
--coccinelle check with coccinelle (spatch) while building;
- --check-only=FILE check only files listed in FILE;
-M, --kmake-opts additional options to append to the final kernel
compilation 'make' command
(e.g., W=2 KALLSYMS_EXTRA_PASS=1)
@@ -108,7 +107,7 @@ make_target()
aiaiai-locker $split -l "$lockfile" -c \
"make $keep_going -j $jobs -C $kernel_tree ${arch:+ARCH="$arch"} \
${cross:+CROSS_COMPILE="$cross"} ${objdir:+O="$objdir"} \
- CHECK=\"aiaiai-checker $sparse $smatch $cppcheck $coccinelle $check_only --\" \
+ CHECK=\"aiaiai-checker $sparse $smatch $cppcheck $coccinelle --\" \
KCFLAGS='-Wno-missing-field-initializers -Wno-sign-compare' \
C=$check ${check:+CF="-D__CHECK_ENDIAN__"} W=1 SHELL=\"aiaiai-locker $split -l $lockfile\" \
$kmake_opts $target"
@@ -129,7 +128,7 @@ cleanup_handler()
}
set_cleanup_handler cleanup_handler
-TEMP=`getopt -n $PROG -o o:,D:,j:,O:,E:,k:,a:,M:,v,h --long objdir:,defconfig:,jobs:,stdout:,stderr:,keep-going,arch:,sparse,smatch,cppcheck,coccinelle,check-only:,kmake-opts:,verbose,help -- "$@"` ||
+TEMP=`getopt -n $PROG -o o:,D:,j:,O:,E:,k:,a:,M:,v,h --long objdir:,defconfig:,jobs:,stdout:,stderr:,keep-going,arch:,sparse,smatch,cppcheck,coccinelle,kmake-opts:,verbose,help -- "$@"` ||
fail_usage ""
eval set -- "$TEMP"
@@ -143,7 +142,6 @@ sparse=
smatch=
cppcheck=
coccinelle=
-check_only=
check=0
kmake_opts=
verbose=
@@ -199,10 +197,6 @@ while true; do
coccinelle="--coccinelle"
check=1
;;
- --check-only)
- check_only="--check-only $(opt_check_read "$1" "$2")"
- shift
- ;;
-M|--kmake-opts)
kmake_opts="$2"
shift
--
1.8.5.3
More information about the aiaiai
mailing list